Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Increase specificity to get correct style #18238

Merged
merged 1 commit into from
Nov 7, 2019
Merged

[core] Increase specificity to get correct style #18238

merged 1 commit into from
Nov 7, 2019

Conversation

oliviertassinari
Copy link
Member

Closes #16609.

This is a follow-up on #18156. It mixes two approaches. While the approach in #18156 is preferred for supporting any type of children. The "force side-effect" approach can be interesting with a very specialized component like I suspect ButtonGroup is.

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Nov 6, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 4d260e8...074892b

bundle Size Change Size Gzip Change Gzip
ButtonGroup ▲ +17.7 kB (+28.17% ) 80.3 kB ▲ +5.1 kB (+26.12% ) 24.6 kB
@material-ui/core ▲ +59 B (+0.02% ) 349 kB ▼ -5 B (-0.01% ) 95.6 kB
@material-ui/core[umd] ▲ +53 B (+0.02% ) 309 kB ▲ +4 B (0.00% ) 88.9 kB
ExpansionPanelActions ▲ +13 B (+0.02% ) 60.5 kB ▲ +14 B (+0.07% ) 18.9 kB
DialogActions ▲ +13 B (+0.02% ) 60.5 kB ▲ +13 B (+0.07% ) 18.9 kB
CardActions ▲ +13 B (+0.02% ) 60.5 kB ▲ +9 B (+0.05% ) 18.9 kB
Button ▼ -11 B (-0.01% ) 77.7 kB ▼ -298 B (-1.24% ) 23.8 kB
ButtonBase ▼ -4 B (-0.01% ) 72.3 kB ▼ -4 B (-0.02% ) 22.6 kB
MenuList ▼ -1 B (-0.00% ) 64.4 kB ▲ +2 B (+0.01% ) 20.1 kB
Typography ▲ +1 B (0.00% ) 62.1 kB ▼ -2 B (-0.01% ) 19.3 kB
Backdrop ▼ -1 B (-0.00% ) 66.2 kB ▼ -1 B (-0.00% ) 20.4 kB
Fab ▼ -1 B (-0.00% ) 75.1 kB ▼ -1 B (-0.00% ) 23.3 kB
FilledInput ▼ -1 B (-0.00% ) 72 kB ▼ -1 B (-0.00% ) 22.3 kB
List ▼ -1 B (-0.00% ) 60.8 kB ▲ +1 B (+0.01% ) 18.9 kB
MenuItem ▲ +1 B (0.00% ) 76.4 kB ▲ +1 B (0.00% ) 23.8 kB
Popover ▼ -1 B (-0.00% ) 81 kB ▲ +1 B (0.00% ) 25 kB
Select ▼ -1 B (-0.00% ) 112 kB ▼ -1 B (-0.00% ) 33.4 kB
Tooltip ▲ +1 B (0.00% ) 97.7 kB ▲ +1 B (0.00% ) 30.9 kB
Chip ▲ +1 B (0.00% ) 81 kB -- 24.7 kB
Collapse ▼ -1 B (-0.00% ) 66.3 kB -- 20.5 kB
OutlinedInput ▼ -1 B (-0.00% ) 72.5 kB -- 22.5 kB
Paper ▲ +1 B (0.00% ) 60.7 kB -- 18.9 kB
Dialog -- 80.9 kB ▼ -11 B (-0.04% ) 25.1 kB
SwipeableDrawer -- 90.1 kB ▲ +7 B (+0.03% ) 28 kB
SpeedDialAction -- 114 kB ▲ +6 B (+0.02% ) 36 kB
Tabs -- 83.7 kB ▲ +6 B (+0.02% ) 26.7 kB
Checkbox -- 80.1 kB ▲ +5 B (+0.02% ) 25.1 kB
DialogContentText -- 62.5 kB ▲ +5 B (+0.03% ) 19.6 kB
Slide -- 24.1 kB ▼ -5 B (-0.06% ) 8.21 kB
SpeedDialIcon -- 63 kB ▲ +5 B (+0.03% ) 19.8 kB
AppBar -- 62.2 kB ▲ +4 B (+0.02% ) 19.5 kB
DialogContent -- 60.7 kB ▲ +4 B (+0.02% ) 19 kB
ExpansionPanelDetails -- 60.4 kB ▲ +4 B (+0.02% ) 18.9 kB
Fade -- 22 kB ▼ -4 B (-0.05% ) 7.6 kB
Switch -- 79.4 kB ▼ -4 B (-0.02% ) 24.7 kB
ExpansionPanelSummary -- 76.4 kB ▼ -3 B (-0.01% ) 24.1 kB
IconButton -- 74.4 kB ▼ -3 B (-0.01% ) 23.2 kB
Input -- 70.9 kB ▼ -3 B (-0.01% ) 22.1 kB
Modal -- 14.2 kB ▲ +3 B (+0.06% ) 4.96 kB
TableCell -- 62.5 kB ▲ +3 B (+0.02% ) 19.6 kB
TableSortLabel -- 75.6 kB ▲ +3 B (+0.01% ) 23.9 kB
useAutocomplete -- 11.7 kB ▼ -3 B (-0.07% ) 4.32 kB
Zoom -- 22.1 kB ▼ -3 B (-0.04% ) 7.6 kB
Autocomplete -- 125 kB ▲ +2 B (+0.01% ) 39.6 kB
Avatar -- 61.2 kB ▲ +2 B (+0.01% ) 19.3 kB
BottomNavigationAction -- 73.8 kB ▲ +2 B (+0.01% ) 23.3 kB
Breadcrumbs -- 66.4 kB ▼ -2 B (-0.01% ) 20.8 kB
Card -- 61.2 kB ▲ +2 B (+0.01% ) 19.1 kB
CardMedia -- 60.8 kB ▲ +2 B (+0.01% ) 19.1 kB
Container -- 61.6 kB ▲ +2 B (+0.01% ) 19.2 kB
DialogTitle -- 62.7 kB ▲ +2 B (+0.01% ) 19.7 kB
Divider -- 61 kB ▲ +2 B (+0.01% ) 19.1 kB
ExpansionPanel -- 69.7 kB ▲ +2 B (+0.01% ) 21.7 kB
FormControlLabel -- 64 kB ▲ +2 B (+0.01% ) 20.1 kB
LinearProgress -- 63.8 kB ▲ +2 B (+0.01% ) 19.9 kB
Popper -- 28.5 kB ▲ +2 B (+0.02% ) 10.2 kB
Snackbar -- 75.6 kB ▲ +2 B (+0.01% ) 23.5 kB
styles/createMuiTheme -- 15.2 kB ▲ +2 B (+0.04% ) 5.36 kB
TableRow -- 61 kB ▼ -2 B (-0.01% ) 19.1 kB
ToggleButton -- 74.4 kB ▼ -2 B (-0.01% ) 23.5 kB
Toolbar -- 60.8 kB ▲ +2 B (+0.01% ) 19 kB
@material-ui/lab -- 169 kB ▲ +1 B (0.00% ) 50.9 kB
@material-ui/styles -- 50.8 kB ▲ +1 B (+0.01% ) 15.4 kB
@material-ui/system -- 14.8 kB ▲ +1 B (+0.02% ) 4.06 kB
Badge -- 63.8 kB ▲ +1 B (+0.01% ) 19.7 kB
Box -- 69.2 kB ▼ -1 B (-0.00% ) 20.9 kB
CardContent -- 60.4 kB ▲ +1 B (+0.01% ) 18.9 kB
CardHeader -- 63.5 kB ▲ +1 B (+0.01% ) 20 kB
CircularProgress -- 62.5 kB ▲ +1 B (+0.01% ) 19.7 kB
ClickAwayListener -- 3.85 kB ▲ +1 B (+0.06% ) 1.55 kB
CssBaseline -- 56 kB ▲ +1 B (+0.01% ) 17.5 kB
Drawer -- 82.7 kB ▼ -1 B (-0.00% ) 25.6 kB
FormGroup -- 60.5 kB ▲ +1 B (+0.01% ) 18.9 kB
FormHelperText -- 61.7 kB ▼ -1 B (-0.01% ) 19.3 kB
FormLabel -- 61.9 kB ▼ -1 B (-0.01% ) 19.1 kB
Grid -- 63.5 kB ▲ +1 B (+0.01% ) 19.9 kB
GridList -- 60.9 kB ▲ +1 B (+0.01% ) 19.1 kB
GridListTile -- 62.2 kB ▲ +1 B (+0.01% ) 19.5 kB
Grow -- 22.6 kB ▲ +1 B (+0.01% ) 7.72 kB
Hidden -- 64.5 kB ▲ +1 B (0.00% ) 20.2 kB
Icon -- 61.2 kB ▲ +1 B (+0.01% ) 19.2 kB
InputBase -- 69.1 kB ▼ -1 B (-0.00% ) 21.6 kB
ListItem -- 75.4 kB ▲ +1 B (0.00% ) 23.5 kB
ListItemAvatar -- 60.6 kB ▲ +1 B (+0.01% ) 18.9 kB
ListItemIcon -- 60.6 kB ▲ +1 B (+0.01% ) 19 kB
ListItemSecondaryAction -- 60.5 kB ▲ +1 B (+0.01% ) 18.9 kB
ListItemText -- 63.4 kB ▲ +1 B (+0.01% ) 19.9 kB
ListSubheader -- 61.2 kB ▲ +1 B (+0.01% ) 19.2 kB
MobileStepper -- 66.2 kB ▲ +1 B (0.00% ) 20.6 kB
NativeSelect -- 75.2 kB ▲ +1 B (0.00% ) 23.7 kB
Portal -- 2.87 kB ▲ +1 B (+0.08% ) 1.3 kB
Radio -- 80.9 kB ▲ +1 B (0.00% ) 25.4 kB
RootRef -- 4.43 kB ▼ -1 B (-0.06% ) 1.67 kB
Skeleton -- 60.9 kB ▲ +1 B (+0.01% ) 19.1 kB
Slider -- 73.9 kB ▼ -1 B (-0.00% ) 23.3 kB
SpeedDial -- 84.3 kB ▼ -1 B (-0.00% ) 26.5 kB
Step -- 61.1 kB ▲ +1 B (+0.01% ) 19.1 kB
StepButton -- 80.6 kB ▲ +1 B (0.00% ) 25.3 kB
StepIcon -- 63.1 kB ▲ +1 B (+0.01% ) 19.6 kB
StepLabel -- 67 kB ▼ -1 B (-0.00% ) 21 kB
SvgIcon -- 61.5 kB ▼ -1 B (-0.01% ) 19.1 kB
TextareaAutosize -- 5.06 kB ▲ +1 B (+0.05% ) 2.11 kB
TextField -- 121 kB ▲ +1 B (0.00% ) 35.4 kB
ToggleButtonGroup -- 61.6 kB ▲ +1 B (+0.01% ) 19.4 kB
TreeItem -- 71.9 kB ▼ -1 B (-0.00% ) 22.6 kB
useMediaQuery -- 2.49 kB ▼ -1 B (-0.10% ) 1.05 kB
BottomNavigation -- 60.8 kB -- 19 kB
CardActionArea -- 73.3 kB -- 23.1 kB
colorManipulator -- 3.83 kB -- 1.52 kB
docs.landing -- 55.6 kB -- 14.6 kB
docs.main -- 603 kB -- 192 kB
FormControl -- 62.8 kB -- 19.5 kB
GridListTileBar -- 61.7 kB -- 19.3 kB
InputAdornment -- 63.5 kB -- 20 kB
InputLabel -- 63.8 kB -- 19.8 kB
Link -- 65 kB -- 20.6 kB
Menu -- 86.6 kB -- 27.2 kB
NoSsr -- 2.19 kB -- 1.04 kB
RadioGroup -- 61.7 kB -- 19.3 kB
Rating -- 68.3 kB -- 21.8 kB
SnackbarContent -- 64.1 kB -- 20.1 kB
StepConnector -- 61.2 kB -- 19.2 kB
StepContent -- 67.4 kB -- 21 kB
Stepper -- 63.2 kB -- 19.9 kB
Tab -- 74.6 kB -- 23.6 kB
Table -- 61 kB -- 19.1 kB
TableBody -- 60.5 kB -- 18.9 kB
TableFooter -- 60.6 kB -- 18.9 kB
TableHead -- 60.6 kB -- 18.9 kB
TablePagination -- 139 kB -- 40.5 kB
TreeView -- 64.8 kB -- 20.2 kB

Generated by 🚫 dangerJS against 074892b

@oliviertassinari oliviertassinari merged commit 6c6d8e0 into mui:master Nov 7, 2019
@oliviertassinari oliviertassinari deleted the actions-specificity-issue branch November 7, 2019 15:03
@Kizmar Kizmar mentioned this pull request Nov 8, 2019
Closed
2 tasks
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiled css precedence
2 participants
@oliviertassinari @mui-pr-bot