Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add funding entry to manifests #18250

Merged
merged 1 commit into from
Nov 7, 2019
Merged

[core] Add funding entry to manifests #18250

merged 1 commit into from
Nov 7, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 7, 2019

npm@^6.13.0 added the funding field

I included it in packages that don't have other mui peer dependencies with a funding field and are "substantial". This includes /core, /system and /styles.

/cc @mui-org/board-members

@eps1lon eps1lon added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. package: system Specific to @mui/system package: material-ui Specific to @mui/material labels Nov 7, 2019
oliviertassinari
oliviertassinari approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://trello.com/c/jpboCoIK/2129-funding-field

👍

@eps1lon eps1lon changed the title [core] Add function entry to manifests [core] Add funding entry to manifests Nov 7, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing b29c294...9811d8d

Generated by 🚫 dangerJS against 9811d8d

@eps1lon eps1lon merged commit 3e13a29 into mui:master Nov 7, 2019
@eps1lon eps1lon deleted the release/add-funding branch November 7, 2019 14:56
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
package: material-ui Specific to @mui/material package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari