-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix bug on disableOpenOnFocus prop #18380
Merged
oliviertassinari
merged 4 commits into
mui:master
from
netochaves:bug/AutoCompleteDisableOpenOnFocus
Nov 16, 2019
Merged
[Autocomplete] Fix bug on disableOpenOnFocus prop #18380
oliviertassinari
merged 4 commits into
mui:master
from
netochaves:bug/AutoCompleteDisableOpenOnFocus
Nov 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 64ae0c6...5711581
|
@netochaves Could you add a regression test? Thanks. |
oliviertassinari
added
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
labels
Nov 15, 2019
netochaves
force-pushed
the
bug/AutoCompleteDisableOpenOnFocus
branch
from
November 15, 2019 18:11
1d6e3ed
to
d6169cc
Compare
I've added the tests @oliviertassinari. I'm new with regressions tests, please let me know if I've done something wrong. |
oliviertassinari
changed the title
[AutoComplete] Fix bug on disableOpenOnFocus prop
[Autocomplete] Fix bug on disableOpenOnFocus prop
Nov 15, 2019
@netochaves Thanks, I have extended the test case and removed the new demo as we already cover the case in the "Playground". |
oliviertassinari
added
PR: ready to ship
and removed
PR: needs revision
The pull request can't be merged. More details is available on the code review or fails in the CI
labels
Nov 15, 2019
@netochaves Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18360