[test] Improve coverage #18385
Merged
[test] Improve coverage #18385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistent with other error messages and markdown
eps1lon
commented
Nov 15, 2019
| @@ -280,7 +281,7 @@ const SpeedDial = React.forwardRef(function SpeedDial(props, ref) { | |||
|
|
|||
| const allItems = React.Children.toArray(childrenProp).filter(child => { | |||
| if (process.env.NODE_ENV !== 'production') { | |||
| if (child.type === React.Fragment) { | |||
There was a problem hiding this comment.
Less usage of react internals
eps1lon
commented
Nov 15, 2019
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const theme = useTheme(); | ||
| if (!theme.shadows[elevation]) { | ||
| if (classes[`elevation${elevation}`] === undefined) { |
There was a problem hiding this comment.
We could technically move this into propTypes but I wanted to avoid adding hurdles when migrating from withStyles to makeStyles.
Nice side-effect is that styles creation and this warning are now decoupled. Previously refactoring of how we would create the elevation classes would require refactoring this check.
eps1lon
commented
Nov 15, 2019
| } | ||
|
|
||
| if (typeof htmlFontSize !== 'number') { | ||
| console.error(`Material-UI: 'htmlFontSize' is required to be a number.`); | ||
| console.error('Material-UI: `htmlFontSize` is required to be a number.'); |
There was a problem hiding this comment.
Backticks mimic how we display inline code in markdown.
eps1lon
commented
Nov 15, 2019
| @@ -35,9 +36,6 @@ function textCriteriaMatches(nextFocus, textCriteria) { | |||
| // jsdom doesn't support innerText | |||
| text = nextFocus.textContent; | |||
| } | |||
| if (text === undefined) { | |||
There was a problem hiding this comment.
Could not find info why this would be undefined. It can be null apparently but I wouldn't know when and so far we never encountered this.
Details of bundle changes.Comparing: 4ce0f41...177dc61
|
oliviertassinari
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly dev-only warnings that weren't tested. It helps to test those to get a better picture of the warning that will be displayed.