Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Fix virtualization demo #18455

Merged
merged 3 commits into from
Nov 20, 2019
Merged

[Autocomplete] Fix virtualization demo #18455

merged 3 commits into from
Nov 20, 2019

Conversation

PranshuPanwar
Copy link
Contributor

@PranshuPanwar PranshuPanwar commented Nov 19, 2019 •
edited by oliviertassinari
Loading

fixes #18448

@oliviertassinari oliviertassinari changed the title autocompleted change [Autocomplete] Fix virtualization demo Nov 19, 2019
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation component: autocomplete This is the name of the generic UI component, not the React module! labels Nov 19, 2019
@oliviertassinari
Copy link
Member

@mandrin17299 Could you run yarn docs:typescript:formatted to update the JavaScript demo? Thanks.

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 19, 2019 •
edited
Loading

No bundle size changes comparing 508f9a3...963a849

Generated by 🚫 dangerJS against 963a849

@PranshuPanwar
Copy link
Contributor Author

@oliviertassinari , are these changes correct ?
Thanks.

@oliviertassinari oliviertassinari merged commit 0fe1797 into mui:master Nov 20, 2019
@oliviertassinari
Copy link
Member

@mandrin17299 Thanks

@Janpot
Copy link
Member

Janpot commented Nov 20, 2019

@oliviertassinari I think #16859 got closed accidentally instead of #18448

@oliviertassinari
Copy link
Member

Thank you

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autocomplete] Virtualization codesandbox broken
4 participants
@PranshuPanwar @oliviertassinari @mui-pr-bot @Janpot