[styles] Fix ThemeProvider requiring full theme #18500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
typescript
package: styles
eps1lon
force-pushed
the
fix/styles/ThemeProvider-partial
branch
from
108ce10
to
5483f0e
Compare
eps1lon
commented
Nov 22, 2019
| ...defaultTheme, | ||
| palette: { | ||
| ...defaultTheme.palette, | ||
| secondary: { |
There was a problem hiding this comment.
The merge is not deep which is now explicit with types. Fixes
Hovered:
Old
New
eps1lon
commented
Nov 22, 2019
|
No bundle size changes comparing 2b04ee9...5483f0e |
oliviertassinari
approved these changes
Nov 22, 2019
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 25, 2019
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 25, 2019
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 25, 2019
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
ThemeProvidermerges the outer theme shallowly with the passedtheme. Providing a partial theme is sufficient.Future Work:
DefaultThemeinMuiThemeProvidergeneric.