-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Clarify transform-runtime, runtime version #18512
Conversation
I'm going to assume you already found these but adding them here anyways. |
@merceyz Thanks for the link! I didn't look into it much. Just wanted to throw CI quickly at this to see what this even does and then look into it more. |
Switching from draft to bump azure pipelines. Just guessing that this is the cause. |
0fce0a2
to
2c13472
Compare
Details of bundle changes.Comparing: d30e6bb...9455045
|
2c13472
to
f3bce63
Compare
I'm leaving this on hold for now until the upstream PRs are resolved. |
f3bce63
to
9455045
Compare
@eps1lon This was reverted upstream vercel/next.js#10233 |
I give up working with the zeit team. No communication. No discussion. Zeit changes good, other changes bad. Why? Don't care. Pros still stand:
cons are missing due to lack of communication. |
I always assumed transform-runtime and runtime version need to be related. Turns out there's actually an option to specify the
@babel/runtime
version which isn't documented but a maintainer mentioned on SO (https://stackoverflow.com/a/54066848/3406963).I'm opening a PR to the babel docs first to see if this is still considered public. Opening here to see if this has actual bundle size implications.