[docs] Improve the SvgIcon documentation #18560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
svg-icon-update
branch
from
8a99669
to
8c34fb8
Compare
|
No bundle size changes comparing 69d36bb...b6f88b9 |
mbrookes
reviewed
Nov 25, 2019
mbrookes
reviewed
Nov 25, 2019
| {{"demo": "pages/components/icons/SvgIcons.js"}} | ||
| {{"demo": "pages/components/icons/SvgIconsSize.js"}} | ||
|
|
||
| ### Component prop |
There was a problem hiding this comment.
The controversial part.
There was a problem hiding this comment.
There is an ongoing discussion in #17287 regarding removing the support for this prop.
oliviertassinari
force-pushed
the
svg-icon-update
branch
from
1d6c6e9
to
09ce5a0
Compare
mbrookes
reviewed
Nov 25, 2019
mbrookes
reviewed
Nov 25, 2019
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Matt <github@nospam.33m.co>
mbrookes
reviewed
Nov 25, 2019
mbrookes
previously requested changes
Nov 27, 2019
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Matt <github@nospam.33m.co>
joshwooding
approved these changes
Nov 29, 2019
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18431
Closes #17287