-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RadioGroup] Update useRadioGroup.d.ts #19001
Conversation
Remove unnecessary `export {}`. This is a follow-up to PR #18920.
No bundle size changes comparing d57c223...d14242f |
I have noticed that we use this approach in a couple of other places. Are they all justified? |
@oliviertassinari I think they are because they occur in files that have a local |
@oliviertassinari upon further inspection, there's https://github.com/mui-org/material-ui/blob/fb0ab9d667a911459a47a66e64d2e27ec7185bc3/packages/material-ui-types/index.d.ts#L3-L4 that uses Lastly, there's https://github.com/mui-org/material-ui/blob/fb0ab9d667a911459a47a66e64d2e27ec7185bc3/packages/material-ui/src/FormControl/useFormControl.d.ts#L4-L5 where @eps1lon said #18920 (comment)
so I could add that change to this PR? If I touch more than 1 component, is the commit scope |
@NMinhNguyen Thanks |
Remove unnecessary
export {}
.This is a follow-up to PR #18920 (sorry, I forgot to remove this when I inlined
ContextFromPropsKey
).