-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Skeleton] Add wave animation support #19014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
new feature
New feature or request
breaking change
component: skeleton
This is the name of the generic UI component, not the React module!
labels
Dec 28, 2019
oliviertassinari
force-pushed
the
skeleton-wave
branch
from
December 28, 2019 23:41
2e27095
to
b0c7012
Compare
@material-ui/lab: parsed: +0.20% , gzip: +0.21% Details of bundle changes.Comparing: f3218f2...b0c7012
|
@oliviertassinari It would have been nice if that breaking change was documented in the release notes, instead of being hidden over here. |
I agree. I will update the release note |
This was referenced Feb 23, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: skeleton
This is the name of the generic UI component, not the React module!
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reflection around the support for this animation has started in #18913 (comment).
It's a breaking change for people that disable the animation: