Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Distinguish JSSProperties and CSSProperties #19263

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 16, 2020

Our internal "CSSProperties" are tied to our particular CSS-in-JS implementation. However, in some places (e.g. https://github.com/mui-org/material-ui/blob/75c06bcda7fdc6bd316d3d8c196c0d1ce94905cc/docs/src/pages/components/selects/MultipleSelect.tsx#L100 or https://github.com/mui-org/material-ui/blob/0d10a7b9ba1a9b4e61ffd2c2b194f39e03f2e180/docs/src/pages/customization/components/DynamicInlineStyle.tsx#L44) this type is passed to style attributes. It works right now but is the wrong abstraction and blocks experimental type refactorings to address #19113

@eps1lon eps1lon added docs Improvements or additions to the documentation typescript package: material-ui Specific to @mui/material labels Jan 16, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 16, 2020

No bundle size changes comparing f1080b6...78f5ec8

Generated by 🚫 dangerJS against 78f5ec8

@eps1lon eps1lon changed the title [core] Distinguish react from jss CSSProperties [core] Distinguish JSSProperties and CSSProperties Jan 17, 2020
@eps1lon eps1lon force-pushed the fix/distinguish-css-properties branch 2 times, most recently from 604e5bb to dbe9756 Compare January 17, 2020 12:24
@eps1lon eps1lon force-pushed the fix/distinguish-css-properties branch from dbe9756 to d345232 Compare January 20, 2020 11:13
@eps1lon eps1lon merged commit d30e6bb into mui:master Jan 20, 2020
@eps1lon eps1lon deleted the fix/distinguish-css-properties branch January 20, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants