Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TableRow] Improve hover/selected styles #19277

Merged
merged 4 commits into from
Jan 22, 2020
Merged

[TableRow] Improve hover/selected styles #19277

merged 4 commits into from
Jan 22, 2020

Conversation

elmeerr
Copy link
Contributor

@elmeerr elmeerr commented Jan 17, 2020

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 17, 2020 •
edited
Loading

Details of bundle changes.

Comparing: 58d7fd9...aa4fe26

bundle Size Change Size Gzip Change Gzip
Stepper ▲ +43 B (+0.07% ) 65.1 kB ▲ +38 B (+0.19% ) 20.6 kB
Slider ▲ +43 B (+0.06% ) 76.9 kB ▲ +32 B (+0.13% ) 24.3 kB
Chip ▲ +43 B (+0.05% ) 82.8 kB ▲ +29 B (+0.11% ) 25.4 kB
Link ▲ +43 B (+0.06% ) 66.8 kB ▲ +28 B (+0.13% ) 21.1 kB
Autocomplete ▲ +43 B (+0.03% ) 132 kB ▲ +27 B (+0.07% ) 41.3 kB
Button ▲ +43 B (+0.05% ) 79.9 kB ▲ +27 B (+0.11% ) 24.5 kB
Fab ▲ +43 B (+0.06% ) 77 kB ▲ +26 B (+0.11% ) 24 kB
IconButton ▲ +43 B (+0.06% ) 76.4 kB ▲ +26 B (+0.11% ) 23.9 kB
BottomNavigationAction ▲ +43 B (+0.06% ) 75.7 kB ▲ +25 B (+0.10% ) 23.9 kB
ExpansionPanelDetails ▲ +43 B (+0.07% ) 62.1 kB ▲ +25 B (+0.13% ) 19.5 kB
Drawer ▲ +43 B (+0.05% ) 85 kB ▲ +24 B (+0.09% ) 25.8 kB
Tab ▲ +43 B (+0.06% ) 76.6 kB ▲ +24 B (+0.10% ) 24.2 kB
TableSortLabel ▲ +43 B (+0.06% ) 77.6 kB ▲ +23 B (+0.09% ) 24.4 kB
ToggleButtonGroup ▲ +43 B (+0.07% ) 63.4 kB ▲ +23 B (+0.12% ) 20 kB
Card ▲ +43 B (+0.07% ) 63 kB ▲ +22 B (+0.11% ) 19.7 kB
@material-ui/lab ▲ +43 B (+0.02% ) 185 kB ▲ +21 B (+0.04% ) 55.2 kB
Rating ▲ +43 B (+0.06% ) 70.7 kB ▲ +21 B (+0.09% ) 22.7 kB
Select ▲ +43 B (+0.04% ) 117 kB ▲ +21 B (+0.06% ) 34.6 kB
TablePagination ▲ +43 B (+0.03% ) 144 kB ▲ +21 B (+0.05% ) 42 kB
TextField ▲ +43 B (+0.03% ) 126 kB ▲ +21 B (+0.06% ) 36.6 kB
Backdrop ▲ +43 B (+0.06% ) 68 kB ▲ +20 B (+0.10% ) 21 kB
Snackbar ▲ +43 B (+0.06% ) 75.6 kB ▲ +20 B (+0.08% ) 23.7 kB
Tabs ▲ +43 B (+0.05% ) 85.8 kB ▲ +20 B (+0.07% ) 27.2 kB
Tooltip ▲ +43 B (+0.04% ) 102 kB ▲ +20 B (+0.06% ) 32.4 kB
Avatar ▲ +43 B (+0.07% ) 65.4 kB ▲ +19 B (+0.09% ) 20.6 kB
Collapse ▲ +43 B (+0.06% ) 68.2 kB ▲ +19 B (+0.09% ) 21.1 kB
CardActionArea ▲ +43 B (+0.06% ) 75.3 kB ▲ +18 B (+0.08% ) 23.7 kB
FilledInput ▲ +43 B (+0.06% ) 73.7 kB ▲ +18 B (+0.08% ) 22.9 kB
GridListTile ▲ +43 B (+0.07% ) 63.9 kB ▲ +18 B (+0.09% ) 20 kB
Input ▲ +43 B (+0.06% ) 72.7 kB ▲ +18 B (+0.08% ) 22.7 kB
InputBase ▲ +43 B (+0.06% ) 70.8 kB ▲ +18 B (+0.08% ) 22.3 kB
StepButton ▲ +43 B (+0.05% ) 82.6 kB ▲ +18 B (+0.07% ) 26.1 kB
Switch ▲ +43 B (+0.05% ) 82.4 kB ▲ +18 B (+0.07% ) 26 kB
AppBar ▲ +43 B (+0.07% ) 64.1 kB ▲ +17 B (+0.08% ) 20.1 kB
Badge ▲ +43 B (+0.07% ) 65.5 kB ▲ +17 B (+0.08% ) 20.4 kB
Breadcrumbs ▲ +43 B (+0.06% ) 67.9 kB ▲ +17 B (+0.08% ) 21.3 kB
DialogActions ▲ +43 B (+0.07% ) 62.3 kB ▲ +17 B (+0.09% ) 19.5 kB
FormControlLabel ▲ +43 B (+0.07% ) 65.7 kB ▲ +17 B (+0.08% ) 20.6 kB
Menu ▲ +43 B (+0.05% ) 89 kB ▲ +17 B (+0.06% ) 27.4 kB
OutlinedInput ▲ +43 B (+0.06% ) 75 kB ▲ +17 B (+0.07% ) 23.3 kB
Popover ▲ +43 B (+0.05% ) 83.3 kB ▲ +17 B (+0.07% ) 25.8 kB
Alert ▲ +43 B (+0.05% ) 84 kB ▲ +16 B (+0.06% ) 26.3 kB
ButtonBase ▲ +43 B (+0.06% ) 74.2 kB ▲ +16 B (+0.07% ) 23.3 kB
Container ▲ +43 B (+0.07% ) 63.4 kB ▲ +16 B (+0.08% ) 19.8 kB
DialogContent ▲ +43 B (+0.07% ) 62.4 kB ▲ +16 B (+0.08% ) 19.6 kB
docs.main ▲ +43 B (+0.01% ) 596 kB ▲ +16 B (+0.01% ) 194 kB
ExpansionPanelSummary ▲ +43 B (+0.05% ) 78.3 kB ▲ +16 B (+0.06% ) 24.7 kB
FormControl ▲ +43 B (+0.07% ) 64.6 kB ▲ +16 B (+0.08% ) 20.1 kB
FormLabel ▲ +43 B (+0.07% ) 63.6 kB ▲ +16 B (+0.08% ) 19.8 kB
Icon ▲ +43 B (+0.07% ) 63 kB ▲ +16 B (+0.08% ) 19.7 kB
InputLabel ▲ +43 B (+0.07% ) 65.5 kB ▲ +16 B (+0.08% ) 20.2 kB
List ▲ +43 B (+0.07% ) 62.5 kB ▲ +16 B (+0.08% ) 19.5 kB
ListItem ▲ +43 B (+0.06% ) 77.4 kB ▲ +16 B (+0.07% ) 24.2 kB
MenuItem ▲ +43 B (+0.05% ) 78.4 kB ▲ +16 B (+0.07% ) 24.5 kB
RadioGroup ▲ +43 B (+0.07% ) 64.6 kB ▲ +16 B (+0.08% ) 20.1 kB
StepContent ▲ +43 B (+0.06% ) 69.3 kB ▲ +16 B (+0.07% ) 21.7 kB
SvgIcon ▲ +43 B (+0.07% ) 63.2 kB ▲ +16 B (+0.08% ) 19.8 kB
SwipeableDrawer ▲ +43 B (+0.05% ) 92.5 kB ▲ +16 B (+0.06% ) 28.9 kB
TreeView ▲ +43 B (+0.06% ) 66.8 kB ▲ +16 B (+0.08% ) 21.1 kB
Typography ▲ +43 B (+0.07% ) 63.8 kB ▲ +16 B (+0.08% ) 20 kB
AvatarGroup ▲ +43 B (+0.07% ) 62.4 kB ▲ +15 B (+0.08% ) 19.6 kB
Box ▲ +43 B (+0.06% ) 71 kB ▲ +15 B (+0.07% ) 21.7 kB
ButtonGroup ▲ +43 B (+0.05% ) 83.4 kB ▲ +15 B (+0.06% ) 25.6 kB
CardActions ▲ +43 B (+0.07% ) 62.2 kB ▲ +15 B (+0.08% ) 19.5 kB
CardMedia ▲ +43 B (+0.07% ) 62.5 kB ▲ +15 B (+0.08% ) 19.7 kB
CssBaseline ▲ +43 B (+0.07% ) 57.7 kB ▲ +15 B (+0.08% ) 18.1 kB
ExpansionPanelActions ▲ +43 B (+0.07% ) 62.3 kB ▲ +15 B (+0.08% ) 19.5 kB
ListItemAvatar ▲ +43 B (+0.07% ) 62.3 kB ▲ +15 B (+0.08% ) 19.5 kB
ListItemIcon ▲ +43 B (+0.07% ) 62.4 kB ▲ +15 B (+0.08% ) 19.5 kB
ListItemText ▲ +43 B (+0.07% ) 65.1 kB ▲ +15 B (+0.07% ) 20.5 kB
MenuList ▲ +43 B (+0.06% ) 66.2 kB ▲ +15 B (+0.07% ) 20.7 kB
MobileStepper ▲ +43 B (+0.06% ) 68 kB ▲ +15 B (+0.07% ) 21.4 kB
NativeSelect ▲ +43 B (+0.06% ) 77 kB ▲ +15 B (+0.06% ) 24.3 kB
Radio ▲ +43 B (+0.05% ) 84.3 kB ▲ +15 B (+0.06% ) 26.6 kB
Skeleton ▲ +43 B (+0.07% ) 63.1 kB ▲ +15 B (+0.08% ) 20 kB
Slide ▲ +43 B (+0.17% ) 25.7 kB ▲ +15 B (+0.17% ) 8.75 kB
SpeedDialAction ▲ +43 B (+0.04% ) 119 kB ▲ +15 B (+0.04% ) 37.5 kB
Step ▲ +43 B (+0.07% ) 62.8 kB ▲ +15 B (+0.08% ) 19.7 kB
StepIcon ▲ +43 B (+0.07% ) 64.8 kB ▲ +15 B (+0.07% ) 20.2 kB
TableBody ▲ +43 B (+0.07% ) 62.3 kB ▲ +15 B (+0.08% ) 19.5 kB
TableFooter ▲ +43 B (+0.07% ) 62.3 kB ▲ +15 B (+0.08% ) 19.5 kB
TableHead ▲ +43 B (+0.07% ) 62.3 kB ▲ +15 B (+0.08% ) 19.5 kB
CardContent ▲ +43 B (+0.07% ) 62.1 kB ▲ +14 B (+0.07% ) 19.5 kB
CircularProgress ▲ +43 B (+0.07% ) 64.3 kB ▲ +14 B (+0.07% ) 20.3 kB
Dialog ▲ +43 B (+0.05% ) 83.2 kB ▲ +14 B (+0.05% ) 25.9 kB
DialogContentText ▲ +43 B (+0.07% ) 64.2 kB ▲ +14 B (+0.07% ) 20.2 kB
DialogTitle ▲ +43 B (+0.07% ) 64.4 kB ▲ +14 B (+0.07% ) 20.2 kB
ExpansionPanel ▲ +43 B (+0.06% ) 72.5 kB ▲ +14 B (+0.06% ) 22.7 kB
Fade ▲ +43 B (+0.18% ) 23.6 kB ▲ +14 B (+0.18% ) 8.01 kB
FormGroup ▲ +43 B (+0.07% ) 62.2 kB ▲ +14 B (+0.07% ) 19.5 kB
FormHelperText ▲ +43 B (+0.07% ) 63.5 kB ▲ +14 B (+0.07% ) 20 kB
GridList ▲ +43 B (+0.07% ) 62.7 kB ▲ +14 B (+0.07% ) 19.7 kB
GridListTileBar ▲ +43 B (+0.07% ) 63.4 kB ▲ +14 B (+0.07% ) 19.9 kB
Hidden ▲ +43 B (+0.07% ) 66.1 kB ▲ +14 B (+0.07% ) 20.8 kB
InputAdornment ▲ +43 B (+0.07% ) 65.3 kB ▲ +14 B (+0.07% ) 20.5 kB
ListItemSecondaryAction ▲ +43 B (+0.07% ) 62.2 kB ▲ +14 B (+0.07% ) 19.5 kB
ListSubheader ▲ +43 B (+0.07% ) 62.9 kB ▲ +14 B (+0.07% ) 19.8 kB
Paper ▲ +43 B (+0.07% ) 62.5 kB ▲ +14 B (+0.07% ) 19.5 kB
SnackbarContent ▲ +43 B (+0.07% ) 63.7 kB ▲ +14 B (+0.07% ) 20.1 kB
SpeedDial ▲ +43 B (+0.05% ) 86.5 kB ▲ +14 B (+0.05% ) 27.2 kB
Table ▲ +43 B (+0.07% ) 62.7 kB ▲ +14 B (+0.07% ) 19.7 kB
TableContainer ▲ +43 B (+0.07% ) 62.1 kB ▲ +14 B (+0.07% ) 19.5 kB
ToggleButton ▲ +43 B (+0.06% ) 76.4 kB ▲ +14 B (+0.06% ) 24.2 kB
Toolbar ▲ +43 B (+0.07% ) 62.5 kB ▲ +14 B (+0.07% ) 19.6 kB
TreeItem ▲ +43 B (+0.06% ) 74.2 kB ▲ +14 B (+0.06% ) 23.5 kB
AlertTitle ▲ +43 B (+0.07% ) 64.4 kB ▲ +13 B (+0.06% ) 20.3 kB
BottomNavigation ▲ +43 B (+0.07% ) 62.6 kB ▲ +13 B (+0.07% ) 19.6 kB
CardHeader ▲ +43 B (+0.07% ) 65.2 kB ▲ +13 B (+0.06% ) 20.5 kB
Checkbox ▲ +43 B (+0.05% ) 83.2 kB ▲ +13 B (+0.05% ) 26.3 kB
Divider ▲ +43 B (+0.07% ) 62.8 kB ▲ +13 B (+0.07% ) 19.7 kB
Grow ▲ +43 B (+0.18% ) 24.2 kB ▲ +13 B (+0.16% ) 8.22 kB
LinearProgress ▲ +43 B (+0.07% ) 65.5 kB ▲ +13 B (+0.06% ) 20.5 kB
SpeedDialIcon ▲ +43 B (+0.07% ) 64.7 kB ▲ +13 B (+0.06% ) 20.3 kB
StepConnector ▲ +43 B (+0.07% ) 62.9 kB ▲ +13 B (+0.07% ) 19.8 kB
StepLabel ▲ +43 B (+0.06% ) 68.8 kB ▲ +13 B (+0.06% ) 21.7 kB
styles/createMuiTheme ▲ +43 B (+0.26% ) 16.6 kB ▲ +13 B (+0.22% ) 5.85 kB
TableCell ▲ +43 B (+0.07% ) 64.2 kB ▲ +13 B (+0.06% ) 20.2 kB
Zoom ▲ +43 B (+0.18% ) 23.7 kB ▲ +13 B (+0.16% ) 8.13 kB
Grid ▲ +43 B (+0.07% ) 65.3 kB ▲ +12 B (+0.06% ) 20.5 kB
TableRow ▲ +15 B (+0.02% ) 62.7 kB ▲ +21 B (+0.11% ) 19.7 kB
@material-ui/core ▲ +15 B (0.00% ) 361 kB -- 98.8 kB
@material-ui/core[umd] ▼ -6 B (-0.00% ) 318 kB ▼ -4 B (-0.00% ) 92 kB
@material-ui/styles -- 51.2 kB -- 15.4 kB
@material-ui/system -- 14.8 kB -- 4.07 kB
ClickAwayListener -- 3.91 kB -- 1.55 kB
colorManipulator -- 3.88 kB -- 1.52 kB
docs.landing -- 50.5 kB -- 13.3 kB
Modal -- 14.5 kB -- 5.05 kB
NoSsr -- 2.19 kB -- 1.04 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.92 kB -- 1.3 kB
RootRef -- 4.24 kB -- 1.64 kB
TextareaAutosize -- 5.12 kB -- 2.14 kB
useAutocomplete -- 14.6 kB -- 5.26 kB
useMediaQuery -- 2.51 kB -- 1.06 kB

Generated by 🚫 dangerJS against aa4fe26

@oliviertassinari oliviertassinari changed the title [TableRow]: align hover/selected styles [TableRow] Improve hover/selected styles Jan 19, 2020
@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jan 19, 2020
@oliviertassinari oliviertassinari added component: table This is the name of the generic UI component, not the React module! and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Jan 21, 2020
@oliviertassinari
Copy link
Member

@eps1lon It sounds like our wish has been answered :). We can put the infrastructure in place for

Capture d’écran 2020-01-21 à 12 06 39
https://material.io/design/interaction/states.html#anatomy

@oliviertassinari oliviertassinari added the design: material This is about Material Design, please involve a visual or UX designer in the process label Jan 21, 2020
oliviertassinari
oliviertassinari approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the values in the theme to match the specification. It's a sensitive change, better wait for the next minor to release it (avoid patches).

mbrookes
mbrookes reviewed Jan 21, 2020
View reviewed changes
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection

eps1lon
eps1lon approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I'm not sure what caused the change of mind but at least we have one issue out of the way. Time to look into the Button spec again.

@oliviertassinari oliviertassinari merged commit 7ced513 into mui:master Jan 22, 2020
@oliviertassinari
Copy link
Member

Well I'm not sure what caused the change of mind

@eps1lon I think that the new (unless I have missed it) specification page on the visual states had a great influence :).

@elmeerr elmeerr deleted the feature/table-row-style branch January 22, 2020 12:10
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Jan 23, 2020
@elmeerr @EsoterikStare
[TableRow] Improve hover/selected styles (mui#19277)
e35bfbc
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
This was referenced Feb 23, 2020
Open
Closed
Merged
This was referenced Mar 20, 2020
Merged
Merged
This was referenced Apr 6, 2020
Open
Closed
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes left review comments

@eps1lon eps1lon eps1lon approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Material Design States
5 participants
@elmeerr @mui-pr-bot @oliviertassinari @mbrookes @eps1lon