[core] Add debug values to various hooks #19515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
new feature
eps1lon
commented
Feb 1, 2020
| @@ -201,7 +201,7 @@ export default function makeStyles(stylesOrCreator, options = {}) { | |||
| classNamePrefix, | |||
| }; | |||
|
|
|||
| return (props = {}) => { | |||
| const useStyles = (props = {}) => { | |||
There was a problem hiding this comment.
vs.
We could potentially incorporate the name option into the display name of the hook but that might be confusing if the hook name changes between components. Usually you only have a single useStyles per component and even if you have more than 1 then the name will be reflected in the debug value.
Details of bundle changes.Comparing: 1ee2a0d...70fbc15 Details of page changes
|
oliviertassinari
approved these changes
Mar 4, 2020
eps1lon
force-pushed
the
feat/styles-hook-devtools-name
branch
from
18a4214
to
1d1ee90
Compare
eps1lon
commented
Mar 17, 2020
| // skip | ||
| // import * as React from 'react' | ||
| // if (__DEV__) React.useDebugValue() | ||
| ignoreWarning = true; |
There was a problem hiding this comment.
@TrySound Is this expected from rollup? Feels like it should not warn here but remove the import. Or is this terser territory?
There was a problem hiding this comment.
Let's leave this as a console.warn as opposed to throwing as a reminder that this isn't fully dce'd (Dead Code Elimination). It's only 23Bytes anyway.
oliviertassinari
approved these changes
Mar 19, 2020
eps1lon
force-pushed
the
feat/styles-hook-devtools-name
branch
from
816c164
to
70fbc15
Compare
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
|
This is now available:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useThemedisplays the themeuseMediaQuerydisplays{ query: string, match: boolean }makeStylesnow has a name and returns the class keys with their name i.e.Record<string, string>useFocusVisiblereturns the focus-visible stateShould be visible as soon as facebook/react#18070 is released.