-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix GitHub's demo behavior #19928
Conversation
Details of bundle changes.Comparing: 7285bbd...22d34a5 Details of page changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Th tests are now misleading. Could you adjust the props passed so that the assertions stay the same and make sure to add a separate test that describes what you did in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking on the empty input is closing the Popper instead of just getting the focus.I think, if inputValue will be undefined the problem is solved
packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js
Outdated
Show resolved
Hide resolved
Hii @oliviertassinari, Visual regression test |
@hasanozacar I think that the priority should be to update the pull request to match the proposed direction in #19836. As far as I know, fixing this bug shouldn't request to change any existing test. I believe in its current form, the logic would introduce a regression, |
@hasanozacar Do you plan to follow up on the proposed changes? |
e62d5ee
to
013fce5
Compare
d2c725f
to
926f428
Compare
60cc525
to
22d34a5
Compare
@hasanozacar Thanks! |
Closes #19836