Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Let failed types-next jobs pass #20017

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 7, 2020

Continuation of #20007. CircleCI uses the last exit code so set +e has not effect unless the last command exits with 0.

@oliviertassinari
Copy link
Member

Does it mean we can remove set +e? Is this already the default?

@eps1lon
Copy link
Member Author

eps1lon commented Mar 7, 2020

Does it mean we can remove set +e? Is this already the default?

It won't reach exit 0 without set +e.

@mui-pr-bot
Copy link

No bundle size changes comparing 96bad38...103cca4

Generated by 🚫 dangerJS against 103cca4

@eps1lon eps1lon merged commit 440a68f into mui:master Mar 7, 2020
@eps1lon eps1lon deleted the ci/green-ts-next branch March 7, 2020 14:02
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants