[core] Enable module augmentation of CommonColors #20212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
new feature
Details of bundle changes.Comparing: 8b32809...2fe0e5f Details of page changes
|
oliviertassinari
approved these changes
Mar 21, 2020
|
Still need to test this :) |
|
I couldn't test it on codesandbox https://codesandbox.io/s/bold-voice-8z7l3, but on a naked Next.js environment, I could
|
|
@oliviertassinari Thanks. Kind of forgot this one. |
|
@eps1lon Nice finding with the fix :)! |
|
@eps1lon Thank you for fixing this! |
|
@eps1lon @oliviertassinari Thanks for the quick turnaround. I really admire and respect the hard work you contribute to this project. It really shows in the quality. Thank you!!! |
|
@eps1lon Maybe I'm missing something but sadly this doesn't fix the full issue. import { makeStyles, createStyles } from '@material-ui/core/styles';
const useTableToolbarStyles = makeStyles(theme => ...It works when used like this: import { makeStyles, createStyles, Theme } from '@material-ui/core/styles';
const useTableToolbarStyles = makeStyles((theme: Theme) => ...The first worked before. Is that intended? Seems quite annoying to have to define the type of |
|
@levrik Could you provide a clonable repository with your approach and usage? Make sure you're following the approach outlined in the docs and https://codesandbox.io/s/bold-voice-8z7l3 |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20180
Allows
createMuiTheme({ palette: { common: { red: 'pink' } } })withNeed to test this with csb deploy.