-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MenuList] Remove if-statement that is always true #20270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
Remove if-statement that is always true
[Menu] Remove if-statement that is always true
Mar 25, 2020
oliviertassinari
added
component: menu
This is the name of the generic UI component, not the React module!
performance
labels
Mar 25, 2020
eps1lon
added
package: material-ui
Specific to @mui/material
and removed
component: menu
This is the name of the generic UI component, not the React module!
performance
labels
Mar 25, 2020
oliviertassinari
approved these changes
Mar 25, 2020
eps1lon
changed the title
[Menu] Remove if-statement that is always true
[MenuList] Remove if-statement that is always true
Mar 25, 2020
Details of bundle changes.Comparing: 4092ff4...ecdb077 Details of page changes
|
@CptWesley Thanks for taking the time to open a pull request :) |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed if-statement always evaluates to true due to the non-null const nature of
newChildProps
and thus seems unnecessary.