-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slide] Mark direction
as optional in TypeScript
#20338
Merged
eps1lon
merged 1 commit into
mui:master
from
maksimgm:bug/Slide_Wrong_direction_TypeScript_definition
Mar 30, 2020
Merged
[Slide] Mark direction
as optional in TypeScript
#20338
eps1lon
merged 1 commit into
mui:master
from
maksimgm:bug/Slide_Wrong_direction_TypeScript_definition
Mar 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 964f9ab...7aee0c8 Details of page changes
|
maksimgm
changed the title
[Slide] Wrong direction TypeScript definition #20084
[Slide] Wrong direction TypeScript definition
Mar 30, 2020
oliviertassinari
added
component: slider
This is the name of the generic UI component, not the React module!
typescript
labels
Mar 30, 2020
eps1lon
changed the title
[Slide] Wrong direction TypeScript definition
[Slide] Mark Mar 30, 2020
direction
as optional in TypeScript
@maksimgm Thanks! |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 6, 2020
This was referenced Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20084