[ClickAwayListener] Fix support for removed DOM node #20409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 078fd1e...435b0f7 Details of page changes
|
oliviertassinari
changed the title
oliviertassinari
added
component: ClickAwayListener
oliviertassinari
changed the title
|
Good news, we can actually solve the problem. I couldn't write an automated test for it, but could manually confirm it with: import React from 'react';
import ClickAwayListener from '@material-ui/core/ClickAwayListener';
const Demo = () => {
const [visible, setVisible] = React.useState(true);
return visible ? (
<button
type="button"
onClick={() => {
setVisible(false);
}}
>
Will be removed from DOM
</button>
) : null;
};
/**
* how you used the components
*/
export default function Demo2() {
const handleClickAway = () => {
console.log('fired')
};
return (
<div>
<Demo />
<ClickAwayListener onClickAway={handleClickAway}>
<div>Menu 1</div>
</ClickAwayListener>
</div>
);
} |
oliviertassinari
force-pushed
the
click-away-listener
branch
from
b49a9b7
to
435b0f7
Compare
|
@seare-kidane Thank you! |
@oliviertassinari Thank you for actually fixing this problem! |
@oliviertassinari Looks like the bug still exists. After updating |
|
Hi @seare-kidane , I follow what you did and updated the @material-ui/core to 4.9.9 in my project and check from the node_modules files that the changes in this PR isn't there, and then I checked the commit log, it seems that this PR isn't included in 4.9.9? |
|
I tried changing my package.json to this but my app is failing with `Module not found: Error: Can't resolve '@material-ui/core'. Currently, I also encounter these weird Clickaway closing on itself when clicking Select component inside, but I'm not sure how to apply this new PR fixes to my app :( |
|
Could you confirm that we are good at https://codesandbox.io/s/inspiring-newton-337c6? @pawlarius I'm curious, what was your process for figuring out how to use this patch? |
|
@oliviertassinari Confirming the fix on code sandbox works! |
|
@oliviertassinari Actually I am not sure how to use this patch, so I just try using commit id directly 😅. But I've just checked how you apply the patch on your sandbox 👍 @seare-kidane hope this will be included in the next release 🙇♀ |
|
It will be included in the next release, this weekend. |
This was referenced Apr 13, 2020
This was referenced Apr 14, 2020
This was referenced May 4, 2020
This was referenced May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc.documentElementcheck, for raisingonClickAwayeventCloses #20197