-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Card] Migrate to testing-library #20773
Merged
oliviertassinari
merged 6 commits into
mui:master
from
marcosvega91:feature/Card/testingLibrary
Apr 26, 2020
Merged
[Card] Migrate to testing-library #20773
oliviertassinari
merged 6 commits into
mui:master
from
marcosvega91:feature/Card/testingLibrary
Apr 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcosvega91
commented
Apr 26, 2020
- [X ] I have followed (at least) the PR section of the contributing guide.
marcosvega91
changed the title
[Card] migrate all card component to testing library
[Card] migrate all card components to testing library
Apr 26, 2020
marcosvega91
changed the title
[Card] migrate all card components to testing library
[Card] migrate all card components to testing-library
Apr 26, 2020
Details of bundle changes.Comparing: 79085fc...6184297 Details of page changes
|
oliviertassinari
changed the title
[Card] migrate all card components to testing-library
[Card] Migrate to testing-library
Apr 26, 2020
oliviertassinari
added
component: card
This is the name of the generic UI component, not the React module!
test
labels
Apr 26, 2020
Because of tests are run on multiple browser is better to check only if the images are the same and not all the value In local the value is url(foo.jpg) In chrome the value is url("foo.jpg") In safari the value is url(localhost:111/foo.jpg)
@marcosvega91 Thanks! We have many tests to migrate, it's going to be a long road. For the complex ones, feel free to ping @eps1lon, I believe he will enjoy helping. |
Step by step we'll do everything 😄 |
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.