-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Allow default actions of nested elements #20777
Merged
oliviertassinari
merged 1 commit into
mui:master
from
eps1lon:docs/reset-focus-prevent-default
Apr 26, 2020
Merged
[docs] Allow default actions of nested elements #20777
oliviertassinari
merged 1 commit into
mui:master
from
eps1lon:docs/reset-focus-prevent-default
Apr 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
docs
Improvements or additions to the documentation
accessibility
a11y
labels
Apr 26, 2020
Details of bundle changes.Comparing: cbae0f8...4595e44 Details of page changes
|
2 tasks
Awesome, I didn't notice it too in the review 🤷♂️ |
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20724 (comment) by using the original implementation (not using focusable container but a hidden focusable marker).
I was a bit suprised that
Event.preventDefault()
inmousedown
would prevent text-selection but that is even defined in the UI-Events spec. Mousedown-focus behavior I couldn't find but generally elements can have multiple default actions which makes event.preventDefault arguable named badly.