Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Collapsible] Invalid aria-controls on the trigger when closed and keepMounted={false} #1024

Closed
mj12albert opened this issue Dec 10, 2024 · 2 comments · Fixed by #1028
Closed

[Collapsible] Invalid aria-controls on the trigger when closed and keepMounted={false} #1024

mj12albert opened this issue Dec 10, 2024 · 2 comments · Fixed by #1028
Assignees
@mj12albert
Labels
bug 🐛 Something doesn't work component: collapsible This is the name of the generic UI component, not the React module!
Milestone
1.0.0-alpha.1 rel...

Comments

@mj12albert
Copy link
Member

mj12albert commented Dec 10, 2024 •
edited by github-actions bot
Loading

image

Search keywords:
@mj12albert mj12albert added bug 🐛 Something doesn't work component: collapsible This is the name of the generic UI component, not the React module! labels Dec 10, 2024
@mj12albert mj12albert added this to the 1.0.0-alpha.1 release milestone Dec 10, 2024
@mj12albert mj12albert self-assigned this Dec 10, 2024
@mj12albert mj12albert mentioned this issue Dec 10, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@mj12albert
Copy link
Member Author

aria-controls can reference a hidden element though there are strong objections: w3c/aria#531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mj12albert mj12albert

Labels
bug 🐛 Something doesn't work component: collapsible This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
1.0.0-alpha.1 release
Development

Successfully merging a pull request may close this issue.

[Collapsible] Fix trigger aria-controls referencing nonexistent id mj12albert/base-ui
1 participant
@mj12albert