Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ButtonGroup] Create the unstyled component #28

Open
Tracked by #10
michaldudak opened this issue Jul 19, 2023 · 1 comment
Open
Tracked by #10

[ButtonGroup] Create the unstyled component #28

michaldudak opened this issue Jul 19, 2023 · 1 comment
Labels
component: button group This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@michaldudak
Copy link
Member

michaldudak commented Jul 19, 2023 •
edited
Loading

This is the place to gather ideas, measure interest and discuss the API and implementation details of the button group component.

See #10 for the umbrella issue to track progress on Base UI and mui/material-ui#6218 for the problem this project solves.
@michaldudak michaldudak mentioned this issue Feb 27, 2024
Open
32 tasks
@michaldudak michaldudak changed the title ButtonGroup [ButtonGroup][base] Create the unstyled component and hook Jul 19, 2023
@michaldudak michaldudak changed the title [ButtonGroup][base] Create the unstyled component and hook [ButtonGroup][base-ui] Create the unstyled component and hook Aug 18, 2023
@michaldudak michaldudak transferred this issue from mui/material-ui Feb 27, 2024
@michaldudak michaldudak changed the title [ButtonGroup][base-ui] Create the unstyled component and hook [ButtonGroup] Create the unstyled component and hook Feb 27, 2024
@michaldudak michaldudak added new feature New feature or request component: button group This is the name of the generic UI component, not the React module! labels Feb 27, 2024
@michaldudak michaldudak changed the title [ButtonGroup] Create the unstyled component and hook [ButtonGroup] Create the unstyled component Nov 6, 2024
@mj12albert
Copy link
Member

mj12albert commented Dec 6, 2024 •
edited
Loading

I'm thinking we may not need a ButtonGroup component:

  • there's no such thing in ARIA as a button group
  • ToggleGroup already provides roving focus for a group of toggle buttons

So the only feature I can think of that a ButtonGroup could provide is a roving focus around several (non-toggle) buttons, does that already overlap with a Toolbar component that uses role="toolbar"?

(Without roving focus, it's no different from a generic role="group" around several non-toggle buttons)

As a reference, the only feature/prop that is styling-unrelated on Material UI's ButtonGroup is disabled: https://master--material-ui.netlify.app/material-ui/api/button-group/

CC @colmtuite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: button group This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
Base UI
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaldudak @mj12albert