-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Bring useId() to Base UI #616
Comments
@oliviertassinari why option 1 feels odd to you? |
@yash49 If sandwiches Floating UI with Base UI. I don't remember ever seeing this in the open source ecosystem, and I assume it's for good reasons: it becomes completely interdependant but with hard to sync release cycles. |
This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. |
Summary
The logic we have in here:
base-ui/packages/mui-base/src/utils/useId.ts
Line 4 in 890b49e
made sense in the context of moving Base UI out of http://github.com/mui/material-ui to its own repository quickly.
But it makes no sense in the long term. We want the dependency tree of @base-ui/react to be as lean as possible. It can't have @mui/ dependencies. So I believe it should work the other way around: be a helper that Base UI exposes for Material UI, MUI X, etc. https://npm.anvaka.com/#/view/2d/%2540base_ui%252Freact
Examples
No response
Motivation
This is a subset of https://www.notion.so/mui-org/engineering-mui-utils-purpose-9a9fc9da3a004864b6c4e1f4d1f24f95.
Also to be noted that this logic will stay duplicated in the bundle of users. It duplicate with: https://github.com/floating-ui/floating-ui/blob/2f5132ede1f02758bc5f8b96647e97deb546771c/packages/react/src/hooks/useId.ts#L39. If we really want to obsess over bundle size, I see two possible solutions:
Search keywords: -
The text was updated successfully, but these errors were encountered: