Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Popper over Popover for desktop? #1426

Closed
developdeez opened this issue Dec 17, 2019 · 1 comment · Fixed by #1850
Closed

Use Popper over Popover for desktop? #1426

developdeez opened this issue Dec 17, 2019 · 1 comment · Fixed by #1850
Assignees
Labels
enhancement New feature or request important Need work

Comments

@developdeez
Copy link

Just noticed this but when date picker is opened in dropdown-like form the scroll of the page is hidden. Causes the design to shift slightly.

@oliviertassinari oliviertassinari added the enhancement New feature or request label Jan 4, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 4, 2020

@developdeez The design shift you are referring to is related to another issue on https://github.com/mui-org/material-ui side. You can learn more about it their. In your case, you might need to apply the .mui-fixed class name on the fixed or absolute positioned elements.


However, your feedback uncovers another interesting behavior. The full-screen version of the picker opens a dialog modal, blocking the interactions with the rest of the page are expected and the usage of the Modal component sounds like the best choice for mobile.

But the inline version uses it too, it blocks interactions with the rest of the page. I really think that it shouldn't on a desktop. I think that the usage of the Popper component would be much better for this use case. We have a related discussion in mui/material-ui#17353 and mui/material-ui#11243 (comment).

@oliviertassinari oliviertassinari changed the title DatePicker hides scroll Use Popper over Popover for desktop? Jan 4, 2020
@dmtrKovalenko dmtrKovalenko self-assigned this Jan 13, 2020
@oliviertassinari oliviertassinari added the important Need work label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request important Need work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants