Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IconButton] IconButtons should have the same hover effect as flat buttons #10869

Closed
1 task done
SebastianSchmidt opened this issue Mar 31, 2018 · 4 comments
Closed
1 task done
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process

Comments

@SebastianSchmidt
Copy link
Contributor

SebastianSchmidt commented Mar 31, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

IconButtons should have the same hover effect as flat buttons (Example).

Current Behavior

IconButtons have no hover effect (Specification).

Steps to Reproduce

Buttons demo

Context

The difference between IconButtons and (flat) buttons is noticeable, for example, when both appear in combination in an AppBar.

Your Environment

Tech Version
Material-UI 1.0.0-beta.39
React 16.2.0
Browser Firefox 59, Chromium 59, Chromium 65
@SebastianSchmidt
Copy link
Contributor Author

If this behavior is confirmed as an error, I will take care of a correction.

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 31, 2018

@SebastianSchmidt Two benchmarks that go against your proposition:

But I believe that material-web-components are developed in tight relation with the Material Design Team. It's often safe to follow them. cc @mbrookes.

@SebastianSchmidt
Copy link
Contributor Author

I think it would be consistent if IconButtons have a hover effect; other button-like components also have a hover effect in Material-UI (for example Menu items and Chips). However, there are other clickable components that do not have a hover effect in Material-UI (for example Tabs and Expansion panels). However, the Tabs from material-web-components have a hover effect. Material-UI may be inconsistent at this point. Perhaps it would make sense to adjust the hover effects in Material-UI so that the components behave consistently to each other.

@SebastianSchmidt
Copy link
Contributor Author

SebastianSchmidt commented Mar 31, 2018

I have created an own issue in which I will list all components with inconsistent hover effects: #10870

@oliviertassinari oliviertassinari added the design: material This is about Material Design, please involve a visual or UX designer in the process label Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

No branches or pull requests

2 participants