-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[doc] Adding the 'type' attribute description of <ButtonBase> #11683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@chocolatl Yes, I can confirm this point: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button.
I'm all 💯 with you on this pain point. There is room for improvement. We should improve the description: |
@chocolatl Do you want to work on it? |
@oliviertassinari I'm afraid not, My English is very bad 😓. |
@oliviertassinari Can I fix this? Do we only want to add the prop's description in the doc? Or change the default value of it to |
@pnkapadia6 Of course, no need to ask :). The default value is expected. We need to make the behavior explicit in the API documentation page. |
Uh oh!
There was an error while loading. Please reload this page.
In HTML, the default value of the
type
attribute of the<button>
tag is"submit"
, but in MDUI's<ButtonBase>
, the default value of thetype
attribute is"button"
, which results in no form submission behavior by default.This difference was confusing to me, although the
type
attribute of<ButtonBase>
can be specified, but the doc did not give instructions, I hope to add a description of thetype
attribute in the documentThe text was updated successfully, but these errors were encountered: