Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField and Input component margins don't match #11717

Closed
2 tasks done
urkopineda opened this issue Jun 5, 2018 · 1 comment
Closed
2 tasks done

TextField and Input component margins don't match #11717

urkopineda opened this issue Jun 5, 2018 · 1 comment
Labels
support: question Community support but can be turned into an improvement

Comments

@urkopineda
Copy link
Contributor

urkopineda commented Jun 5, 2018

TextField has 3 different margin property enum available: normal, dense and none; while Input only dense and none.

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Input component should have normal, dense and none margins (adding normal)

Current Behavior

Input component only has dense and none margins.

Steps to Reproduce (for bugs)

  1. Run this code.

Context

I think that, being TextField and other components an implementation of Input component, both should have the same margin property available values.

Your Environment

Tech Version
Material-UI v1.2.0
React v16.4.0
browser Chrome v66.0.3359.139
@oliviertassinari oliviertassinari added new feature New feature or request support: question Community support but can be turned into an improvement and removed new feature New feature or request labels Jun 5, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 5, 2018

@urkopineda The margin property you are looking for is in the FormControl component. Not the Input.

-<FormControl className={classes.formControl}>
+<FormControl className={classes.formControl} margin="normal">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support: question Community support but can be turned into an improvement
Projects
None yet
Development

No branches or pull requests

2 participants