Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge SwipeableDrawer styling through PaperProps #11799

Closed
2 tasks done
angrybacon opened this issue Jun 10, 2018 · 0 comments
Closed
2 tasks done

Merge SwipeableDrawer styling through PaperProps #11799

angrybacon opened this issue Jun 10, 2018 · 0 comments
Labels
good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@angrybacon
Copy link

angrybacon commented Jun 10, 2018 •
edited by oliviertassinari
Loading

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

I want to be able to provide custom styling for the inner Paper component through PaperProps.

Current Behavior

The style attribute is being overwritten in SwipeableDrawer:
https://github.com/mui-org/material-ui/blob/8cbfd1fc59dfb4c8ec76ff1296b3a59306a3e09c/packages/material-ui/src/SwipeableDrawer/SwipeableDrawer.js#L356-L360

Steps to Reproduce (for bugs)

https://codesandbox.io/s/3qol95n215

  1. Narrow the viewport enough to utilize the swipeable drawer
  2. Observe the inner paper not getting hotpink background

Your Environment

Tech Version
Material-UI v1.2.0
React v16.4.0
@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label Jun 10, 2018
@angrybacon angrybacon mentioned this issue Jun 10, 2018
Closed
@Johann-S Johann-S mentioned this issue Jun 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @angrybacon