Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definitions in TouchRipple.d.ts are not in sync with TouchRipple.js #11803

Closed
andeshc opened this issue Jun 10, 2018 · 1 comment
Closed
Labels
component: ButtonBase The React component. good first issue Great for first contributions. Enable to learn the contribution process. typescript

Comments

@andeshc
Copy link

andeshc commented Jun 10, 2018

Type definitions in TouchRipple.d.ts are not in sync with TouchRipple.js
The TouchRippleClassKey is defined as
export type TouchRippleClassKey =
| 'root'
| 'wrapper'
| 'wrapperLeaving'
| 'wrapperPulsate'
| 'ripple'
| 'rippleVisible'
| 'ripplePulsate';

While the one actually implemented in TouchRipple.js has "child" instead of "wrapper", "childLeaving" instead of "wrapperLeaving" and "childPulsate" instead of "wrapperPulsate"

  • [ x] This is a v1.x issue (v0.x is no longer maintained).
  • [ x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Current Behavior

Steps to Reproduce (for bugs)

Context

Your Environment

Tech Version
Material-UI v1.?.?
React
browser
etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ButtonBase The React component. good first issue Great for first contributions. Enable to learn the contribution process. typescript
Projects
None yet
Development

No branches or pull requests

2 participants