Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-popper to v1 #11855

Closed
ccamusso opened this issue Jun 14, 2018 · 6 comments
Closed

Update react-popper to v1 #11855

ccamusso opened this issue Jun 14, 2018 · 6 comments
Assignees
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation

Comments

@ccamusso
Copy link

Hi,
your 'MenuList composition' example in official documentation:
https://material-ui.com/demos/menus/

not work:
https://codesandbox.io/s/38q476vomq

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Jun 14, 2018
@oliviertassinari
Copy link
Member

Yeah, react-popper just released a new version, stick to v0.x for now. https://github.com/FezVrasta/react-popper/releases/tag/v1.0.0

@ccamusso
Copy link
Author

Thank you,
work with react-popper 0.10.4

Can you update you documentation?

@oliviertassinari
Copy link
Member

I'm will update the project to rely on react-popper@1

@oliviertassinari oliviertassinari changed the title React-popper example not work Update react-popper to v1 Jun 14, 2018
@nbkhope
Copy link

nbkhope commented Jun 19, 2018

I'm curious as to why material-ui upgraded to popper v1 in a patch version. The codebase I work with relies on the popper components and when v1.2.2 was released, our app broke because we had dependency permitting a minor version 1.2.2 to be installed.

@TrySound
Copy link
Contributor

TrySound commented Jun 19, 2018

@nbkhope Did you have popper in your dependencies or did you use transitive one?

@oliviertassinari
Copy link
Member

@nbkhope There is an eslint plugin to help you identifying transitive dependencies. I would encourage you to use it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

4 participants