Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] tooltips block pointer events even when not showing #11913

Closed
2 tasks done
jedwards1211 opened this issue Jun 19, 2018 · 3 comments
Closed
2 tasks done

[Regression] tooltips block pointer events even when not showing #11913

jedwards1211 opened this issue Jun 19, 2018 · 3 comments
Assignees
Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module!

Comments

@jedwards1211
Copy link
Contributor

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

When a tooltip isn't showing it can't block any elements from receiving pointer events

Current Behavior

Even when the tooltip isn't showing, its div is present in the document, blocking any elements beneath it from receiving pointer events

Steps to Reproduce (for bugs)

  1. Go to https://codesandbox.io/s/vqnzr43xv7
  2. Hover in the middle of the "Button blocked by tooltip"
  3. Notice that the button isn't clickable in the middle
  4. Hover around the sides of the button -- the tooltip doesn't block it on the sides

Context

Your Environment

Tech Version
Material-UI v1.2.2
React v16.4.0
browser Chrome 66.0.3359.181
@jedwards1211 jedwards1211 changed the title Regression: tooltips block pointer events even when not showing [Regression] tooltips block pointer events even when not showing Jun 19, 2018
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jun 19, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 19, 2018

I have also noticed that scrolling performance is much worse 😱, plus the increased bundle-size : #11862.
Maybe we should go back to react-popper@0.x?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 19, 2018

I'm reverting back to react-popper@0.x. There is, what I think is a leak in react-popper@1.
Moving forward, I'm gonna take the weekend to fix all the tooltip issues in a batch.

@geirsagberg
Copy link
Contributor

I think the issue with this might be that className should no longer be on Popper element, but on the <div> within?

@oliviertassinari oliviertassinari added the component: tooltip This is the name of the generic UI component, not the React module! label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants