Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwipeableDrawer demos broken on iOS #12057

Closed
1 of 2 tasks
mikew opened this issue Jul 4, 2018 · 4 comments
Closed
1 of 2 tasks

SwipeableDrawer demos broken on iOS #12057

mikew opened this issue Jul 4, 2018 · 4 comments
Assignees
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module!

Comments

@mikew
Copy link
Contributor

mikew commented Jul 4, 2018

The swipeable drawers component demos are (severely) broken on iOS.

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Current Behavior

Multiple drawers visible all the time, overlapping drawers, some scroll with the page.

Steps to Reproduce (for bugs)

  1. Visit https://material-ui.com/demos/drawers/ on iOS.
    https://gfycat.com/AcceptableLinearFlicker

Context

Your Environment

  • iOS 11.3.1
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module! labels Jul 5, 2018
@oliviertassinari oliviertassinari changed the title Drawer demos broken on iOS SwipeableDrawer demos broken on iOS Jul 5, 2018
@mikew
Copy link
Contributor Author

mikew commented Jul 6, 2018

In case anyone comes to this issue before the docs are fixed: both the Drawer and SwipeableDrawer components work beautifully on iOS.

@Forfold
Copy link

Forfold commented Jul 17, 2018

Can confirm that with a drawer open, the content behind the div will scroll with your finger as you swipe open/close. I don't think it used to do this

@oliviertassinari oliviertassinari self-assigned this Jul 22, 2018
@oliviertassinari
Copy link
Member

I was able to track down the root of the issue. It's a SSR mismatch on the demos from this line:
https://github.com/mui-org/material-ui/blob/a2c69371bec6629995b67f080b3a5808cf4e07bb/packages/material-ui/src/SwipeableDrawer/SwipeableDrawer.js#L451-L452

I'm fixing it.

@oliviertassinari
Copy link
Member

@mikew Thanks for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants