Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error occurs when dialog closing #12092

Closed
perevezencev opened this issue Jul 9, 2018 · 1 comment
Closed

Error occurs when dialog closing #12092

perevezencev opened this issue Jul 9, 2018 · 1 comment
Labels
component: dialog This is the name of the generic UI component, not the React module! support: question Community support but can be turned into an improvement

Comments

@perevezencev
Copy link

Expected Behavior

Close Dialog without crash

Current Behavior

Error occurs when dialog closing

Context

Edit 7z258m8z36

Your Environment

Tech Version
Material-UI v1.3.0
React v16.4.0
@oliviertassinari
Copy link
Member

@perevezencev It's expected, the dialog rerender the body during the closing transition. You can change the logic, add a pure logic or use the modal https://codesandbox.io/s/n5r728249l.

@oliviertassinari oliviertassinari added support: question Community support but can be turned into an improvement component: dialog This is the name of the generic UI component, not the React module! labels Jul 9, 2018
This was referenced Mar 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! support: question Community support but can be turned into an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @perevezencev