Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableBody css api missing #12116

Closed
chrishenx opened this issue Jul 11, 2018 · 6 comments
Closed

TableBody css api missing #12116

chrishenx opened this issue Jul 11, 2018 · 6 comments
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@chrishenx
Copy link

chrishenx commented Jul 11, 2018

We can see in this page TableBody that the documentation says the component accepts a classes property, but the css api documentation is missing.

@oliviertassinari oliviertassinari added good first issue Great for first contributions. Enable to learn the contribution process. component: table This is the name of the generic UI component, not the React module! labels Jul 11, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 11, 2018

@chrishenx We just need to export the style in
https://github.com/mui-org/material-ui/blob/355317fb479dc234c6b1e374428578717b91bdc0/packages/material-ui/src/TableBody/TableBody.js#L6

-const styles = {
+export const styles = {

and to rerun the script generating the documentation: yarn docs:api.

Do you want to work on it?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 11, 2018
@chrishenx
Copy link
Author

chrishenx commented Jul 12, 2018

Okay, let me do that. It's going to take me more time than it seems necessary, but I need to setup everything

@chrishenx
Copy link
Author

@oliviertassinari the same applies for the TableFooter, so while in there, I also gonna update it

@chrishenx
Copy link
Author

Also, the documentation for TablePaginationActions is missing

@chrishenx
Copy link
Author

Wait a minute, it might be an implementation detail leaked within the docs of TablePagination

@chenop
Copy link
Contributor

chenop commented Jul 14, 2018

#12147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

No branches or pull requests

3 participants