Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip] Bugs in version 1.4.0 #12154

Closed
2 tasks done
ahce opened this issue Jul 15, 2018 · 5 comments
Closed
2 tasks done

[Tooltip] Bugs in version 1.4.0 #12154

ahce opened this issue Jul 15, 2018 · 5 comments
Assignees
@oliviertassinari
Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module!

Comments

@ahce
Copy link

ahce commented Jul 15, 2018 •
edited by oliviertassinari
Loading

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Bugs

  • Double tooltip: when enterDelay is higher this bug is most visible.
  • Cut tooltip: when the browser scroll is visible.

Expected Behavior v1.3.1

  • Double tooltip
    image
  • Cut tooltip
    image

Current Behavior v1.4.0

  • Double tooltip
    image
  • Cut tooltip
    image

Environment

Tech Version
Material-UI v1.4.1
React v16.4.1
browser chrome 67
@oliviertassinari oliviertassinari self-assigned this Jul 15, 2018
@oliviertassinari
Copy link
Member

when enterDelay is higher this bug is most visible.

Can it be noticed with enterDelay={0}?

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module! labels Jul 15, 2018
@ahce
Copy link
Author

ahce commented Jul 15, 2018

@oliviertassinari Yes, with enterDelay={0} is noticed, but it is more difficult to reproduce.
With this example, FormControlLabel map enterDelay={0}, sometimes the other tooltip is visible.
image

@oliviertassinari
Copy link
Member

@ahce What OS are you using. Could you provide a CodeSandbox?

@ahce
Copy link
Author

ahce commented Jul 16, 2018

@oliviertassinari
Windows 10 1709 build 16299.371
CodeSandbox: https://codesandbox.io/s/n325qlpvrl

@oliviertassinari
Copy link
Member

Thanks. I might have found a solution to the problem. Let's try it out. We can remove the title synchronously on the event trigger. Right now, we wait for the next rAF.

@oliviertassinari oliviertassinari mentioned this issue Jul 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviertassinari oliviertassinari

Labels
bug 🐛 Something doesn't work component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @ahce