Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormControlLabel] required #12180

Closed
Mangatt opened this issue Jul 18, 2018 · 6 comments
Closed

[FormControlLabel] required #12180

Mangatt opened this issue Jul 18, 2018 · 6 comments
Labels
status: waiting for author Issue with insufficient information

Comments

@Mangatt
Copy link
Contributor

Mangatt commented Jul 18, 2018

FormControlLabel component is not displaying correctly that labeled selection control is required with asterisk, as normal FormLabel component.

(Material UI 1.4.0)

@Mangatt Mangatt changed the title FormControlLabel required [FormControlLabel] required Jul 18, 2018
@mbrookes mbrookes added the status: waiting for author Issue with insufficient information label Jul 18, 2018
@mbrookes
Copy link
Member

Your issue has been closed because it does not conform to our issue requirements.
Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

@Mangatt
Copy link
Contributor Author

Mangatt commented Jul 18, 2018

There is actually nothing to reproduce, it's down to component specs:

  • [FormLabel] available props: disabled, error, required
  • [FormControlLabel] available props: disabled

I believe that error & required props should be available to [FormControlLabel] as well because they are functionally similar.

@mbrookes
Copy link
Member

Please use the appropriate issue template for future issues, otherwise it is difficult to help. Your one-liner issue ooked like an incomplete bug report rather than an incomplete feature request.

FormControlLabel is for selection controls. A switch, radio and checkbox can't ordinarily be in an error state or required state – its value is valid regardless.

@Mangatt
Copy link
Contributor Author

Mangatt commented Jul 19, 2018

Ok, sorry for not using proper template.

I don't think that you're right about error state. Even MDN mentions required attribute for checkbox and Chrome displays validation bubble when required attribute is present and checkbox is not checked.

@wnadurski
Copy link

Should this issue be renewed in 2020? I would also like to have an asterisk next to a checkbox label.

@mbrookes
Copy link
Member

"Accept Ts&Cs" could be a valid use case. Please check that there isn't one already, and open a new feature request issue using the appropriate template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

3 participants