[ToggleButton] ToggleButtonGroup onChange props [TS]

[odontogenic]

• This is a Labs issue
• I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

ToggleButtonGroup should accept onChange props

Current Behavior

Error unexpected prop

Fix

Including onChange definition in ToggleButtonGroup.d.ts seems to fix this:

export interface ToggleButtonGroupProps
  extends StandardProps<React.HTMLAttributes<HTMLDivElement>, ToggleButtonGroupClassKey> {
  onChange: (event: React.SyntheticEvent, value: any) =>  void
  selected?: boolean;
  exclusive?: boolean;
  value?: any;
}

[oliviertassinari]

@gingivitis Thanks for raising this issue. We miss the onChange definition. Do you want to submit a pull request with this change? :)

[eps1lon]

Looking at https://github.com/mui-org/material-ui/blob/bb7794ea493041bcb9b2b5b4d343c25eb8849ea5/packages/material-ui-lab/src/ToggleButton/ToggleButtonGroup.js#L42 it looks like no event is passed.

This would also be a good opportunity to make the value generic and see if this provides any value.

[oliviertassinari]

This would also be a good opportunity to make the value generic and see if this provides any value.

@eps1lon Yes, I agree.