Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly helpful correlation in docs for class names + multiple chunk builds #12435

Closed
atrauzzi opened this issue Aug 7, 2018 · 5 comments
Closed
Labels
docs Improvements or additions to the documentation

Comments

@atrauzzi
Copy link
Contributor

atrauzzi commented Aug 7, 2018

Hey everyone (awesome) at MUI!

I just finished successfully troubleshooting a JSS styling issue largely in thanks to a lot of the existing discussion and documentation provided in this repo.

There was one facet of my issue that wasn't covered however that I feel like the docs could be expanded which is to include a mention about the runtimeChunk option in WebPack.

Briefly -- my scenario is that I'm producing a collection of components-per-chunk scripts that all rely on a common chunk. All normal functionality in WebPack, but I realized that I was running the bootstrap stub multiple times. Which of course for MUI meant I was getting multiple instances of the JSS css name generator (oops!).

What I think would be great is to link to this page in the docs somewhere near the FAQ item I linked above: https://webpack.js.org/configuration/optimization/#optimization-runtimechunk

@oliviertassinari
Copy link
Member

@atrauzzi Oh yes! I think that we should be documenting the fact that bundlers might duplicate modules when code splitting 👍. Thanks for raising the issue.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 7, 2018
@oliviertassinari
Copy link
Member

Do you want to update the docs?

@atrauzzi
Copy link
Contributor Author

atrauzzi commented Aug 8, 2018

I can try! What do I have to do? 😄

@oliviertassinari
Copy link
Member

I believe we can add this other source of potential issue in the documentation section you linked: https://material-ui.com/getting-started/faq/#how-to-fix-a-class-names-conflict-in-production-

@atrauzzi
Copy link
Contributor Author

atrauzzi commented Aug 8, 2018

On it! Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants