Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Make thumb in slider component more customizable. #12438

Closed
ksairamya opened this issue Aug 7, 2018 · 9 comments
Closed

[Slider] Make thumb in slider component more customizable. #12438

ksairamya opened this issue Aug 7, 2018 · 9 comments
Labels
component: slider This is the name of the generic UI component, not the React module!

Comments

@ksairamya
Copy link

Should be able to customize thumb in slider component.

Expected Behavior

Customizing thumb should be flexible and have a separate prop for customizing thumb with images or icons.

Current Behavior

currently there is no option to customize the thumb with images. By default is is of type button and styles are applied on that but there is option to change the type of thumb.

Examples

image

Context

currently I'm trying to add a mdi-react LabelIcon as a thumb to the slider but it is not allowing me to do that. Because it is a button and there is option to override that I'm blocked.

slider

@ksairamya

This comment has been minimized.

@oliviertassinari oliviertassinari added component: slider This is the name of the generic UI component, not the React module! package: lab Specific to @mui/lab labels Aug 7, 2018
@adeelibr
Copy link
Contributor

adeelibr commented Aug 12, 2018

#12485 I have made a PR for this feature.

@ksairamya
Copy link
Author

Thank you.

@ksairamya

This comment has been minimized.

@adeelibr
Copy link
Contributor

#12600

@eps1lon
Copy link
Member

eps1lon commented Sep 23, 2018

This was shipped with @material-ui/lab@v3.0.0-alpha.16 in #12600. Is this sufficient for your use case @ksairamya?

@ksairamya
Copy link
Author

yes this is sufficient @eps1lon . Thank you for working on it.

@eps1lon
Copy link
Member

eps1lon commented Sep 24, 2018

That was mainly @adeelibr. I just wanted to make sure that this issue can be closed.

@adeelibr
Copy link
Contributor

Should this issue be closed now? @oliviertassinari

@oliviertassinari oliviertassinari removed the package: lab Specific to @mui/lab label Jan 9, 2021
@oliviertassinari oliviertassinari changed the title Make thumb in slider component more customizable. [Slider] Make thumb in slider component more customizable. Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

4 participants