-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Make thumb in slider component more customizable. #12438
Labels
component: slider
This is the name of the generic UI component, not the React module!
Comments
This comment has been minimized.
This comment has been minimized.
#12485 I have made a PR for this feature. |
Thank you. |
This comment has been minimized.
This comment has been minimized.
This was shipped with |
yes this is sufficient @eps1lon . Thank you for working on it. |
That was mainly @adeelibr. I just wanted to make sure that this issue can be closed. |
Should this issue be closed now? @oliviertassinari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Should be able to customize thumb in slider component.
Expected Behavior
Customizing thumb should be flexible and have a separate prop for customizing thumb with images or icons.
Current Behavior
currently there is no option to customize the thumb with images. By default is is of type button and styles are applied on that but there is option to change the type of thumb.
Examples
Context
currently I'm trying to add a mdi-react LabelIcon as a thumb to the slider but it is not allowing me to do that. Because it is a button and there is option to override that I'm blocked.
The text was updated successfully, but these errors were encountered: