Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Comp default color is not 'default' #14136

Closed
TallOrderDev opened this issue Jan 10, 2019 · 2 comments
Closed

Switch Comp default color is not 'default' #14136

TallOrderDev opened this issue Jan 10, 2019 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@TallOrderDev
Copy link

  • [ x] This is not a v0.x issue.
  • [ x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

The docs indicate that this is NOT the correct behavior, but I think it might be off.

The default value for color on the Switch comp is 'secondary', I would expect it to be 'default'.

Current Behavior 😯

currently if you do not provide a color to the api for color, it will default to 'secondary' and not 'default'. This might be the correct behaviour, but I'd infer default would be default.

Link:

  1. https://material-ui.com/api/switch/

Context 🔦

Not sure what the correct is, just looking for clarity, and I couldn't find an issue that covered this, so I thought I'd open one before we get to far into 1.0

Your Environment 🌎

not important

Tech Version
Material-UI v3.8.3
@joshwooding
Copy link
Member

Related to #13028

@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Jan 11, 2019
@oliviertassinari
Copy link
Member

@TallOrderDev Yes, you are right, this is confusing. We are going to solve this in #13028.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants