Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] classnames presents in Textarea component #14512

Closed
2 tasks done
izorg opened this issue Feb 12, 2019 · 3 comments
Closed
2 tasks done

[v4] classnames presents in Textarea component #14512

izorg opened this issue Feb 12, 2019 · 3 comments
Labels
bug 🐛 Something doesn't work

Comments

@izorg
Copy link

izorg commented Feb 12, 2019

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Success webpack build

Current Behavior 😯

ERROR in ../node_modules/@material-ui/core/esm/InputBase/Textarea.js
Module not found: Error: Can't resolve 'classnames' in '../node_modules/@material-ui/core/esm/InputBase'
 @ ../node_modules/@material-ui/core/esm/InputBase/Textarea.js 10:0-36 186:19-29 194:19-29 203:19-29
 @ ../node_modules/@material-ui/core/esm/InputBase/InputBase.js
 @ ../node_modules/@material-ui/core/esm/InputBase/index.js
 @ ../node_modules/@material-ui/core/esm/TablePagination/TablePagination.js
 @ ../node_modules/@material-ui/core/esm/TablePagination/index.js
 @ ../node_modules/@material-ui/core/esm/index.js

Steps to Reproduce 🕹

Link:

  1. https://unpkg.com/@material-ui/core@4.0.0-alpha.0/esm/InputBase/Textarea.js
  2. https://unpkg.com/@material-ui/core@4.0.0-alpha.0/es/InputBase/Textarea.js
  3. https://unpkg.com/@material-ui/core@4.0.0-alpha.0/InputBase/Textarea.js
  4. Try build with webpack

Context 🔦

Your Environment 🌎

Tech Version
Material-UI v4.0.0-alpha.0
@oliviertassinari
Copy link
Member

Fixed in #14506

@izorg
Copy link
Author

izorg commented Feb 12, 2019

Sorry, thought it was included in v4.0.0-alpha.0. Will wait for next release

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 12, 2019

You can install classnames to workaround the problem. Next release is scheduled this weekend. We can cut one earlier if needed.

@eps1lon eps1lon added the bug 🐛 Something doesn't work label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

3 participants