Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom font with TextField's outlined variant - when 'in focus' the outline does not resize properly #16657

Closed
2 tasks done
gebigoma opened this issue Jul 20, 2019 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@gebigoma
Copy link
Contributor

gebigoma commented Jul 20, 2019

When using a custom font with TextFields Outlined variant the outline doesn't resize properly - it cuts into the label.

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

The outline should resize so that it is completely outside of the label.

Current Behavior 😯

When using a custom font with TextFields Outlined variant the outline doesn't resize properly - it cuts into the label.

Steps to Reproduce 🕹

I've created a sandbox for this, with the custom font uploaded, but for the life of me can't figure out how to make custom font work inside the sandbox BUT here are some screen recordings of my local codebase showing what happens before and after I comment out the font in themes:

with custom font:

ScreenRecording2019-07-19at4 (8)

comment out font:

ScreenRecording2019-07-19at4 (6)

without custom font:

ScreenRecording2019-07-19at4 (7)

Sandbox Link:

  1. https://codesandbox.io/s/material-demo-w44d7
    (failed to make custom font work with code but all the info and files are there.. if this helps in any way)

Context 🔦

Your Environment 🌎

Tech Version
Material-UI v4.2.1
React v16. I 8.3
Browser Chrome v75.0.3770.100
TypeScript v3.5.3
etc.
@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Jul 21, 2019
@oliviertassinari
Copy link
Member

@gebigoma Thanks for the reproduction, I believe it's a duplicate of #16465.

@gebigoma
Copy link
Contributor Author

Used fontFaceObserver package and worked like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants