Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening of Dialog through SpeedDial on mobile does not work #16834

Closed
2 tasks done
kmhigashioka opened this issue Jul 31, 2019 · 2 comments · Fixed by #17301
Closed
2 tasks done

Opening of Dialog through SpeedDial on mobile does not work #16834

kmhigashioka opened this issue Jul 31, 2019 · 2 comments · Fixed by #17301
Assignees
@oliviertassinari
Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module!

Comments

@kmhigashioka
Copy link
Contributor

kmhigashioka commented Jul 31, 2019 •
edited
Loading

Opening of Dialog through SpeedDial does not open the Dialog on mobile resolution. What really happening is that when the user trigger the state to open for dialog, immediately the state is change to false.

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

The open state should stay to true.

Current Behavior 😯

The open state is changing to false immediately after setting of state to open.

Steps to Reproduce 🕹

Link: https://codesandbox.io/s/winter-snow-chyrp

  1. Open browser's dev tool.
  2. Toggle device toolbar. Set to mobile resolution. (iphone, pixel)
  3. Click + icon.
  4. Click gear icon.

Context 🔦

Actually, this works on desktop version. However, when opened on mobile the issue persists.

Your Environment 🌎

Tech Version
Material-UI Core v4.2.1
React v16.8.6
Browser (Brave) v0.66.101
Material-UI Lab v4.0.0-alpha.20
@oliviertassinari oliviertassinari added the component: speed dial This is the name of the generic UI component, not the React module! label Jul 31, 2019
@joshwooding
Copy link
Member

I can reproduce this on an iPhone X. Weirdly it worked a couple of times but after a refresh it broke.

@joshwooding joshwooding added the bug 🐛 Something doesn't work label Aug 6, 2019
@mbrookes
Copy link
Member

mbrookes commented Aug 6, 2019

It seems to depend of the length of the tap on the speed dial. A short tap keeps the dialog open, a slightly longer tap closes it.

@oliviertassinari oliviertassinari self-assigned this Sep 10, 2019
@hashwin hashwin mentioned this issue Sep 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviertassinari oliviertassinari

Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SpeedDial] Rework part of the logic hashwin/material-ui
4 participants
@mbrookes @oliviertassinari @kmhigashioka @joshwooding