Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: <Select native id="my-id"> No Longer Has an Id #18255

Closed
2 tasks done
scottfr opened this issue Nov 7, 2019 · 2 comments · Fixed by #18257
Closed
2 tasks done

Regression: <Select native id="my-id"> No Longer Has an Id #18255

scottfr opened this issue Nov 7, 2019 · 2 comments · Fixed by #18257
Assignees
@eps1lon
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!

Comments

@scottfr
Copy link

scottfr commented Nov 7, 2019 •
edited
Loading

The "id" prop is ignored for <Select>'s that have the "native" prop set.

At some point in the past (maybe a few versions ago) this use to work.

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Steps to Reproduce 🕹

  1. Go to: https://codesandbox.io/s/create-react-app-u2uwe
  2. In the console run document.getElementById('select-id'). Nothing will match showing the id isn't set.
@eps1lon eps1lon self-assigned this Nov 7, 2019
@eps1lon eps1lon added bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! labels Nov 7, 2019
@eps1lon eps1lon mentioned this issue Nov 7, 2019
Merged
@eps1lon
Copy link
Member

eps1lon commented Nov 7, 2019

Verified fix in https://codesandbox.io/s/create-react-app-g0t82

@scottfr
Copy link
Author

scottfr commented Nov 7, 2019

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eps1lon eps1lon

Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Select] Fix id not being present when native eps1lon/material-ui
2 participants
@scottfr @eps1lon