Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppBar] Make dark by default for dark themes #18308

Closed
1 task done
cmeeren opened this issue Nov 10, 2019 · 1 comment · Fixed by #26545
Closed
1 task done

[AppBar] Make dark by default for dark themes #18308

cmeeren opened this issue Nov 10, 2019 · 1 comment · Fixed by #26545
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process
Milestone

Comments

@cmeeren
Copy link
Contributor

cmeeren commented Nov 10, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

According to the MD spec:

In a dark theme, the surface of the top app bar uses a dark color instead of a primary or secondary color.

I propose that in MUI, when setting a theme's palette.type to 'dark', the App Bar is by default rendered with a suitable dark, neutral color instead of the primary color.

Examples 🌈

Screenshot from MD spec:

image

Motivation 🔦

This is a good default that follows the MUI spec. Currently it must be done automatically, e.g. by having the theme override the app bar's color prop to 'default', but that sets it to a very dark color that I'm not sure is correct:

image

@oliviertassinari oliviertassinari added this to the v5 milestone Nov 10, 2019
@oliviertassinari oliviertassinari added the design: material This is about Material Design, please involve a visual or UX designer in the process label Nov 10, 2019
@oliviertassinari
Copy link
Member

@cmeeren Thank you for opening an issue. Yes, we will have to rework this point for v5 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants