-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Follow material design guidelines #18493
Comments
Could you link to a page on material.io showing how Selects open? The link you provided uses a reference implementation that is (as are we sometimes) not always following the latest guidelines. |
https://material.io/develop/web/components/input-controls/select-menus/ links to https://material-components.github.io/material-components-web-catalog/#/component/select I would say the reference implementation should be used as a reference |
I think the spec should be used as a reference. Material components web sometimes don't follow the guidelines either. |
can you provide a link to a spec that includes specific components? the only one i can find is above |
https://material-ui.com/getting-started/supported-components/#supported-components With regards to Select I don't have any which is why I asked you. |
see above |
having the options randomly floating away from the input and sometimes obscuring it is problematic |
@eps1lon I think we have good example here https://material.io/components/menus/menus.html#exposed-dropdown-menu |
@peterchq The position of the select is not random. It's positioned so the selected value displays on top of the closed select state. This behavior can be found on native platforms, like macOS or Windows Edge. macOS Chrome, Safari Windows Edge Windows FireFox, Chrome
@una encourages to refer to material components web when in doubt. But I tend to agree with @eps1lon. It should be significantly simpler to author visual mockups than HTML + JS + CSS, from this perspective, I think that following the visual of material.io should be preferred.
We have started a similar thread in #18136 (comment) and #17636 (comment) and #15055. I have run a benchmark on some design system to compare what's more popular:
|
For now, appears under is the default behavior in @mui/material/Select, how to set appears over? |
Current Behavior 😯
When you click on a select that is not native, the options appear anchored randomly.
Expected Behavior 🤔
clicking on a select should expand the list op options attached to the bottom of the input as in material design guidelines e.g.
https://material-components.github.io/material-components-web-catalog/#/component/select
Steps to Reproduce 🕹
Click on any material-ui select
https://material-ui.com/components/selects/
Steps:
Context 🔦
I am trying to comply with material design guidelines
Your Environment 🌎
The text was updated successfully, but these errors were encountered: