Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current test of createMuiTheme to deep merges multiple arguments is ineffective #18541

Closed
2 tasks done
eedrah opened this issue Nov 24, 2019 · 1 comment · Fixed by #18543
Closed
2 tasks done

Current test of createMuiTheme to deep merges multiple arguments is ineffective #18541

eedrah opened this issue Nov 24, 2019 · 1 comment · Fixed by #18543
Labels

Comments

@eedrah
Copy link
Contributor

eedrah commented Nov 24, 2019

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

I believe the current test to deep merge arguments is ineffective. I am finding that I'm getting errors in this behavior, but before creating an issue with those, I've decided to first fix the test. (There seems to be a lot of code changes around this area anyway, so this might be a more productive way to go. I note that the api went from being undocumented to documented in the last couple of days.)

Expected Behavior 🤔

I'd expect one of the two following mutually exclusive options:

  1. It is agreed that the behavior is unwanted, the test is removed, and the functionality is removed from the docs.
  2. It is agreed that the behavior is wanted, and the tests are updated. Any failing tests should be fixed shortly after.

My vote is for option 2, and a pull request will follow shortly after this.

@eedrah
Copy link
Contributor Author

eedrah commented Nov 24, 2019

Here's the pull request: #18543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants