Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] - Chips should not be bigger than the input #18653

Closed
2 tasks done
fbarbare opened this issue Dec 2, 2019 · 2 comments · Fixed by #18662
Closed
2 tasks done

[Autocomplete] - Chips should not be bigger than the input #18653

fbarbare opened this issue Dec 2, 2019 · 2 comments · Fixed by #18662
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@fbarbare
Copy link
Contributor

fbarbare commented Dec 2, 2019

When the text of the input is too big, the Chip is bigger than the input so it goes out of it

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The value is too big for the input
image

Expected Behavior 🤔

The text displayed should be shrinked so it can fit in the input
image

Steps to Reproduce 🕹

Steps:

  1. Create an autocomplete with a text longer than the defined width of the autocomplete

Context 🔦

I am not in control of the data showed in the input and this is a scenario that has come up. I fixed it by creating the Chip myself and passing style to it, but I thought it'd be best having a solution in the library.

Your Environment 🌎

Tech Version
Material-UI v4.7.1
React v16.12.0
Browser Chrome
TypeScript v3.6.4
Material-UI/Lab v4.0.0-alpha.34
@fbarbare
Copy link
Contributor Author

fbarbare commented Dec 2, 2019

P.S. I can submit a PR with what I did if the solution is approved

@oliviertassinari
Copy link
Member

I believe we would need to fix #18587 first. Happy to see a patch for this problem :).

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. labels Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants