-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Textarea initial height being set to zero #1870
Comments
Regarding the fix. What about using instead a |
Cool I can whip together a PR tomorrow. Just to clarify, you'd be cool with something like this? newHeight = Math.max(newHeight, rowsHeight) Here is the component I used to produce the issue using version <TextField
underlineFocusStyle={underlineStyle}
className="template-upload-field"
ref="description"
onBlur={this.addDetails.bind(this, "description")}
fullWidth={true}
multiLine={true}
hintText="Add a description" /> |
Yes exactly. I think that the |
Submitted PR for this issue, please review: #1875 |
I feel like I should dig into this more though to understand the behaviour... but I need to get something working in the meantime... |
@oliviertassinari pretty backed up on PRs huh? I got another pull request I want to add for documenting certain props of the select field. Do you guys need any help in the PR department? |
After
_syncHeightWithShadow
is called oncomponentDidMount
in the enhanced-textarea.jsx component, it will revert from initial 24 value to 0. As a result, the user is completely blocked from editing the textarea.I managed to temporarily fix it by changing this line:
https://github.com/callemall/material-ui/blob/master/src/enhanced-textarea.jsx#L123
To:
Before the fix
After the fix*
The text was updated successfully, but these errors were encountered: